Skip to content

Conversation

@JayeshVegda
Copy link
Contributor

Search movies using TMDB API. Type 'imdb' followed by a movie name to search. and it will search movie and show rate and soem more details

@cibere
Copy link
Contributor

cibere commented May 26, 2025

Spaces in the filename are fine, and required if you want to have a space in the plugin's name. In fact, the filename in #506 was perfectly fine. I'm not sure why you felt the need to change it.

Nonetheless, please do not create a third pr to fix this issue, just continue adding onto this pr.

@JayeshVegda
Copy link
Contributor Author

@cibere Could you please review this PR? All checks have passed. Thanks!

@JayeshVegda
Copy link
Contributor Author

@Jack251970 Could you please review this PR? All checks have passed. Thanks!

cibere
cibere previously approved these changes May 28, 2025
Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, and it seems to function just fine.

@cibere
Copy link
Contributor

cibere commented May 28, 2025

Though, I wonder if a different plugin name would be more accurate. Since the plugin only uses tmdb, perhaps TMDB Search?
What do you think @Jack251970 and @jjw24?

@Jack251970
Copy link
Member

Jack251970 commented May 29, 2025

Though, I wonder if a different plugin name would be more accurate. Since the plugin only uses tmdb, perhaps TMDB Search? What do you think @Jack251970 and @jjw24?

I do not think it is necessary since the plugin desc already contains this information

@Jack251970
Copy link
Member

@JayeshVegda Everything looks good to me. Just one small suggestion: We typically avoid including the action keyword in the description since users might change it. Could you update the description to something like:

Search movies using TMDB API. Type a movie name to search. Shows movie details and ratings.

If you prefer to keep it as is, that’s fine too.

Jack251970
Jack251970 previously approved these changes May 29, 2025
@JayeshVegda
Copy link
Contributor Author

@cibere, I appreciate the feedback. I chose "Movie Search" to keep it simple for users. Since the description already clarifies the use of TMDB, I feel the name is sufficient. Let me know if you'd prefer a change.

@JayeshVegda
Copy link
Contributor Author

@Jack251970 Thanks for the suggestion! That makes sense. I've updated the description accordingly. Let me know if there's anything else you'd like me to adjust.

@Jack251970
Copy link
Member

@Jack251970 Thanks for the suggestion! That makes sense. I've updated the description accordingly. Let me know if there's anything else you'd like me to adjust.

Please do not forget to change the desc in this PR as well

@Jack251970
Copy link
Member

And Github page if you would like to

image

@JayeshVegda JayeshVegda dismissed stale reviews from Jack251970 and cibere via 6004813 May 29, 2025 06:20
@Jack251970 Jack251970 merged commit 63e5fed into Flow-Launcher:plugin_api_v2 May 29, 2025
6 checks passed
@Jack251970
Copy link
Member

Good👍

@JayeshVegda
Copy link
Contributor Author

Thank you all for the feedback, suggestions, and support!
Glad to have my first plugin merged — really appreciate it 😊
Looking forward to contributing more in the future!

@Jack251970
Copy link
Member

Thank you all for the feedback, suggestions, and support! Glad to have my first plugin merged — really appreciate it 😊 Looking forward to contributing more in the future!

Really love your README.md design! It looks so nice!❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants