-
Notifications
You must be signed in to change notification settings - Fork 161
New Plugin: Movie Search using tmdb api #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Plugin: Movie Search using tmdb api #507
Conversation
|
Spaces in the filename are fine, and required if you want to have a space in the plugin's name. In fact, the filename in #506 was perfectly fine. I'm not sure why you felt the need to change it. Nonetheless, please do not create a third pr to fix this issue, just continue adding onto this pr. |
… Search-cf00c3b8-0fbe-45c1-abbc-25dfdbf7cd92.json
|
@cibere Could you please review this PR? All checks have passed. Thanks! |
|
@Jack251970 Could you please review this PR? All checks have passed. Thanks! |
cibere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, and it seems to function just fine.
|
Though, I wonder if a different plugin name would be more accurate. Since the plugin only uses tmdb, perhaps |
I do not think it is necessary since the plugin desc already contains this information |
|
@JayeshVegda Everything looks good to me. Just one small suggestion: We typically avoid including the action keyword in the description since users might change it. Could you update the description to something like: If you prefer to keep it as is, that’s fine too. |
|
@cibere, I appreciate the feedback. I chose "Movie Search" to keep it simple for users. Since the description already clarifies the use of TMDB, I feel the name is sufficient. Let me know if you'd prefer a change. |
|
@Jack251970 Thanks for the suggestion! That makes sense. I've updated the description accordingly. Let me know if there's anything else you'd like me to adjust. |
Please do not forget to change the desc in this PR as well |
|
Good👍 |
|
Thank you all for the feedback, suggestions, and support! |
Really love your README.md design! It looks so nice!❤️ |

Search movies using TMDB API. Type 'imdb' followed by a movie name to search. and it will search movie and show rate and soem more details